Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swr): strongly type args in swr mutation fetchers #1324

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix(swr): strongly type args in swr mutation fetchers #1324

merged 1 commit into from
Apr 23, 2024

Conversation

AllieJonsson
Copy link
Contributor

@AllieJonsson AllieJonsson commented Apr 23, 2024 •
edited
Loading

Status

READY

Description

This adds the actual body type to the mutation fetcher instead of using the SWR type Arguments.
Fixes #1323 1323

Steps to Test or Reproduce

yarn generate:swr
check petstore/endpoints.ts
notice that getCreatePetsMutationFetcher returns a function that has arg typed as CreatePetsBody, while getDeletePetByIdMutationFetcher still has the Arguments type, since deletePetById does not have a body argument

@AllieJonsson AllieJonsson changed the title fix: strongly type args in swr mutation fetchers fix(swr): strongly type args in swr mutation fetchers Apr 23, 2024
@AllieJonsson AllieJonsson force-pushed the fix/mutation-fetcher-arg branch from 2f18c9f to c1cb2c3 Compare April 23, 2024 07:44
@melloware melloware merged commit 7feae35 into orval-labs:master Apr 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

swr: Mutation fetchers are not strongly typed
2 participants
@AllieJonsson @melloware