Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swr): make sure to not include comma when not valid while generating swrMutationFetcher #1271

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix(swr): make sure to not include comma when not valid while generating swrMutationFetcher #1271

merged 1 commit into from
Mar 19, 2024

Conversation

AllieJonsson
Copy link
Contributor

Status

READY

Description

Fixes #1270

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

  1. Build and then generate swr
  2. Check tests\generated\swr\nested-arrays\endpoints.ts for errors

@melloware melloware added the bug Something isn't working label Mar 19, 2024
@melloware melloware added this to the 6.26.0 milestone Mar 19, 2024
@melloware melloware merged commit ee01104 into orval-labs:master Mar 19, 2024
2 checks passed
@AllieJonsson AllieJonsson deleted the fix/swr-empty-post-method-args branch March 19, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees

@AllieJonsson AllieJonsson

Labels
bug Something isn't working
Projects
None yet
Milestone
6.26.0
Development

Successfully merging this pull request may close these issues.

SWR: Empty post method generates invalid code when using axios options
2 participants
@AllieJonsson @melloware