Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(msw): mock blobs as blobs instead of strings #1269

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

AllieJonsson
Copy link
Contributor

@AllieJonsson AllieJonsson commented Mar 18, 2024

Status

WIP

Fix #1259

Description

Mock blobs, as proposed in my comment of issue #1259

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

yarn build
cd tests
yarn generate:swr
check generated/swr/blob-file export const getGetBinaryBlobResponseMock

@melloware melloware added this to the 6.26.0 milestone Mar 18, 2024
@melloware melloware added the bug Something isn't working label Mar 18, 2024
@melloware
Copy link
Collaborator

This looks good to me. I don't use MSW but this seems reasonable to me.

@melloware melloware merged commit 54df332 into orval-labs:master Mar 18, 2024
2 checks passed
@AllieJonsson AllieJonsson deleted the fix/msw-blob-mock branch March 19, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSW: Incorrect return value generated for Blob mocks
2 participants