fix(core): improve NonReadonly type #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this affects #616. I can't really make sense of the original issue at the moment. It seems the goal was to turn readonly fields into optional fields? Usually we do this as part of the Swagger model definition itself by making the input body field optional |
melloware
approved these changes
Feb 25, 2024
ezequiel
added a commit
to ezequiel/orval
that referenced
this pull request
May 2, 2024
This reverts commit 5b76e3b. Fixes orval-labs#1348
melloware
pushed a commit
that referenced
this pull request
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fixes #1236
Improves the
NonReadonly<T>type so it actually works now. Note: this implementation was taken from ts-essentials' DeepWritable, which seem to have the most accurate type as of nowBefore
After