fix(core): distinguish the value when it is blank only in interface
#1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ma interface (orval-labs#1219)" This reverts commit 97552e4.
|
This PR will be on hold until the discussion in #1227 is over. If you are in a hurry to fix the problem, I think this PR will help you. |
|
@soartec-lab i added my openapi JSON an Orval config in the ticket if you want to verify. |
melloware
requested changes
Feb 28, 2024
| @@ -46,7 +46,10 @@ export const generateInterface = ({ | |||
| scalar.type === 'object' && | |||
| !context?.output.override?.useTypeOverInterfaces | |||
| ) { | |||
| model += `export interface ${name} ${scalar.value}\n`; | |||
| // If `scalar.value` is 'unknown', replace it with `{}` to avoid type error | |||
| const blankIntefaceValue = scalar.value === 'unknown' ? '{}' : scalar.value; | |||
There was a problem hiding this comment.
Suggested change
| const blankIntefaceValue = scalar.value === 'unknown' ? '{}' : scalar.value; | |
| const blankInterfaceValue = scalar.value === 'unknown' ? '{}' : scalar.value; |
| // If `scalar.value` is 'unknown', replace it with `{}` to avoid type error | ||
| const blankIntefaceValue = scalar.value === 'unknown' ? '{}' : scalar.value; | ||
|
|
||
| model += `export interface ${name} ${blankIntefaceValue}\n`; |
There was a problem hiding this comment.
Suggested change
| model += `export interface ${name} ${blankIntefaceValue}\n`; | |
| model += `export interface ${name} ${blankInterfaceValue}\n`; |
|
@melloware |
soartec-lab
changed the title
interface
|
@melloware |
melloware
approved these changes
Mar 1, 2024
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
fix #1227
When I responded to #1219, it caused unintended destruction, so I revert #1219.
This issue occurs when the doesn't have
typelike a bellow:And, the issue where the interface definition results in an error when interface is an blank schema is resolved by replacing the value only in the case of interfaces.
Related PRs
{}insterd ofunknownfor blank schema interface #1219Todos
Steps to Test or Reproduce
orval