fix(msw): changed naming convention for response mock functions to avoid function name conflicts #1217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
fix #1106
This issue is occur when the path name and
operationId
are the same. So a rare case becauseoperationId
is usually used likeaddXX
orgetXXX
, but i will fix it because it causes unintended problems for users.orval
gets the mock name fromtitle
, which is the same naming convention as the response mock.response mock function naming
mock function naming
Ref: https://github.com/anymaniax/orval/blob/master/packages/orval/src/client.ts#L172
Therefore, I changed the response mock function name.
It's a breaking change, but out of all my ideas, I decided to do this because it has the least impact.
Related PRs
Todos
Steps to Test or Reproduce
mock: true
inorval.config.js
orval