-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query): type return of useMutation query #1215
Merged
melloware
merged 6 commits into
orval-labs:master
from
david10sing:fix-add-return-type-to-use-mutation-query
Mar 9, 2024
Merged
fix(query): type return of useMutation query #1215
melloware
merged 6 commits into
orval-labs:master
from
david10sing:fix-add-return-type-to-use-mutation-query
Mar 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david10sing
force-pushed
the
fix-add-return-type-to-use-mutation-query
branch
from
February 11, 2024 00:16
1fa21d6
to
01f8d22
Compare
This LGTM but going to let @anymaniax review. |
@anymaniax could I get your eyes on this please? Thank you 🙏 |
Seems good. Why only for react query? |
Hi @anymaniax, Sorry for the delay in getting back. I am using orval with react-query that's why. I am not sure about the other libraries. |
Updated the mutation queries for |
melloware
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fix #1195
Using
orval
in a repository where thetsconfig
moduleResolution
property is notnode
results in #1195 when producinguseMutation
queries.As per the issue, looks like it needs to be fixed properly upstream but in the meantime, this PR puts in a fix which should silence that error for users using
orval
withmoduleResolution
set to something newer thannode
.Todos
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
yarn build