-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement function generation using useSWRMutation
#1148
Merged
melloware
merged 8 commits into
orval-labs:master
from
soartec-lab:feat/add-use-swr-muration-generator
Jan 13, 2024
Merged
feat: implement function generation using useSWRMutation
#1148
melloware
merged 8 commits into
orval-labs:master
from
soartec-lab:feat/add-use-swr-muration-generator
Jan 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good so far I see you are still working on the failing tests. Appreciate your effort on this! |
Thank you for comment ✨ There are still some problems, I'll let you know when I fix them. |
3 tasks
soartec-lab
force-pushed
the
feat/add-use-swr-muration-generator
branch
from
January 12, 2024 14:23
8129a9a
to
59e64e2
Compare
@melloware @anymaniax |
melloware
approved these changes
Jan 13, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
fix #1013
Originally, in
generateSwrHook
, ifverb
was other thanVerbs.GET
, processing was skipped, but we implemented a function to generate a function usinguseSWRMutation
.Since the processing required for
mutation
is different fromquery
, we have newly addedgenerateSwrMutationImplementation
, which is a function for generating the string of the function itself, andgenerateSwrMutationArguments
, which generates arguments.Also, since
useSWRMutation
requires a dedicatedFetcher
as the second argument, I reused it by wrapping the http function. This allows reuse ofmock
and customization of http client using global mutator.Related PRs
none
Todos
Steps to Test or Reproduce
OpenAPI
definition for petstore that definesmutation
.orval.config.js
orval
for example: