fix: strictly check dependencies import judgment using regular expressions #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soartec-lab
changed the title
soartec-lab
force-pushed
the
feat/strictly-check-dependencies-import
branch
from
768fb67 to
9f349c4
Compare
melloware
requested changes
Jan 6, 2024
| implementation.includes(e.alias || e.name), | ||
| ); | ||
| const toAdds = exports.filter((e) => { | ||
| const petternValues = [e.alias, e.name].filter((p) => p?.length).join('|'); |
There was a problem hiding this comment.
PatternValues not PetternValues
There was a problem hiding this comment.
@melloware
Thank you for review.
I interpreted the name of the variable to be inappropriate. Do you think this is searchWords in the sense of the words you want to search for in a regular expression?
There was a problem hiding this comment.
Yes searchWords would be a good name
There was a problem hiding this comment.
soartec-lab
force-pushed
the
feat/strictly-check-dependencies-import
branch
from
9f349c4 to
5d01571
Compare
melloware
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
fix #1145
I achieved this by using regular expressions to determine.
Related PRs
none
Todos
Steps to Test or Reproduce
orval