-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: possible to generate a function using useSWRInfinite
on the swr
client.
#1138
Merged
melloware
merged 10 commits into
orval-labs:master
from
soartec-lab:feat/add-use-swr-infinite
Jan 3, 2024
Merged
feat: possible to generate a function using useSWRInfinite
on the swr
client.
#1138
melloware
merged 10 commits into
orval-labs:master
from
soartec-lab:feat/add-use-swr-infinite
Jan 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soartec-lab
force-pushed
the
feat/add-use-swr-infinite
branch
from
January 3, 2024 02:47
cfdf5a1
to
4ac88b0
Compare
melloware
approved these changes
Jan 3, 2024
@soartec-lab great PR! Don't worry about sqashing I always Squash PRs on Merge like this... |
Thank you for your review. Also, thank you for teaching me about handling commits. relieved. |
Squashed and merged! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy New Year everyone 🙌
Status
READY
I squash commits if necessary when all reviews are complete.
Description
fix #796
I enabled the
swr
client to define functions usinguseSWRInfinite
. These are generated by specifying them in the configuration file using theoverride
option as shown below:Along with this, we are also making some refactorings:
isEnabled
judgment process and thekey
definition have been separated.Related PRs
none
Todos
Steps to Test or Reproduce
override.swr.useInfinite
totrue
in the configuration file as below:orval
execiteuseSWRInfinite
is generated