fix(core): add missing properties in subschemas to fix TS error

[o-alexandrov]

closes #935

Status

READY

Description

Fixes TypeScript error when accessing a property from a union of objects with different schema.
Please refer to the provided example error in #935

Todos

• Tests
• Documentation
• Changelog Entry (unreleased)

Steps to Test or Reproduce

Run locally to observe the generated types changed (now have missing properties declared as missingProperty?: never in:
- samples/react-query/basic/src/api/model/dog.ts
- samples/react-query/basic/src/api/model/pet.ts

Screenshots of the changes

[o-alexandrov]

@melloware could you please guide on what's missing here to get it merged?

[melloware]

The build is failing with "Code style issues found in 25 files. Forgot to run Prettier?"

[o-alexandrov]

@melloware in terms of prettier, I see there are multiple versions installed (see screenshot)
imho, if I make formatting changes in this PR, I'll add unrelated changes, making it harder for you to review. (you can confirm it by running prettier locally)
In other words, I think the formatting is messed up before this PR.

To fix formatting, we should consider to either:

• remove prettier and other devDependencies from all samples' packages package.json files except the repo's root.
• add samples/* to workspaces in repo's root package.json

Or run formatting in a separate PR.

Screenshot of prettier versions within the repo

[melloware]

@Maxim-Mazurok weren't you proposing something like what @o-alexandrov is asking above?

[Maxim-Mazurok]

I'm pretty sure formatting was fine in the whole project on my PRs. And I may have added prettier checks into CI pipeline to keep it that way. Maybe someone pushed directly into master unformatted code without going through a PR? That would explain unformatted code.

Multiple prettier versions shouldn't be an issue, there's a command to do the formatting in the root project I believe.

Hope this helps. Regarding review I might take a look sometime, but can't promise.

[Maxim-Mazurok]

And IMO - just format it. If it's a really big PR then do another formatting PR, then after it's merged do this one. We can't just merge with failing CI.

[o-alexandrov]

I didn't claim multiple versions of prettier is an issue in the formatting itself.

• it's a duplication for no reason with performance degradations and actual format differences

For your convenience, I'll add a separate PR to fix formatting and then rebase this PR, so this PR contains only related changes to the title

EDIT: formatting regression is addressed in #1117