Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): 暴露 brush 交互的生命周期,便于在 G2Plot 层可以监听 #3485

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jun 19, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@visiky visiky requested a review from hustcc June 19, 2021 14:37
@github-actions
Copy link

github-actions bot commented Jun 19, 2021

🎊 PR Preview c3d622e has been successfully built and deployed to https://antvis-G2-preview-pr-3485.surge.sh?type=diff&date=2021-06-21

🕐 Build time: 77.839s

🤖 By surge-preview

visiky added a commit to antvis/G2Plot that referenced this pull request Jun 19, 2021
visiky added a commit to antvis/G2Plot that referenced this pull request Jun 19, 2021
@visiky visiky force-pushed the export-brush-events branch from c82cdec to df24d25 Compare June 20, 2021 06:09
@coveralls
Copy link

coveralls commented Jun 20, 2021

Pull Request Test Coverage Report for Build 953866504

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 12 of 12 (100.0%) changed or added relevant lines in 4 files are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.007%) to 93.443%

Files with Coverage Reduction New Missed Lines %
src/interaction/action/data/range-filter.ts 1 96.75%
src/chart/view.ts 5 96.83%
src/index.ts 7 97.29%
Totals Coverage Status
Change from base Build 953883161: -0.007%
Covered Lines: 11060
Relevant Lines: 11475

💛 - Coveralls

@visiky visiky force-pushed the export-brush-events branch from df24d25 to 5a74ff7 Compare June 21, 2021 07:47
@visiky visiky force-pushed the export-brush-events branch from 5a74ff7 to ecc59fe Compare June 21, 2021 08:21
src/chart/view.ts Outdated Show resolved Hide resolved
hustcc
hustcc previously approved these changes Jun 21, 2021
visiky added a commit to antvis/G2Plot that referenced this pull request Jun 21, 2021
@visiky visiky merged commit a8690cd into master Jun 21, 2021
@visiky visiky deleted the export-brush-events branch June 21, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants