Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legend): 图例支持回调设置 marker #3448

Merged
merged 2 commits into from
May 31, 2021
Merged

feat(legend): 图例支持回调设置 marker #3448

merged 2 commits into from
May 31, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented May 29, 2021

ref: antvis/component#228, antvis/G2Plot#2558

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@visiky visiky requested a review from hustcc May 29, 2021 02:54
@visiky visiky requested a review from Aarebecca May 29, 2021 03:00
@github-actions
Copy link

github-actions bot commented May 29, 2021

🎊 PR Preview 5b13bb5 has been successfully built and deployed to https://antvis-G2-preview-pr-3448.surge.sh?type=diff

🕐 Build time: 84.649s

🤖 By surge-preview

@coveralls
Copy link

coveralls commented May 29, 2021

Pull Request Test Coverage Report for Build 887416478

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 93.445%

Files with Coverage Reduction New Missed Lines %
src/util/legend.ts 1 96.77%
Totals Coverage Status
Change from base Build 877264083: -0.008%
Covered Lines: 11045
Relevant Lines: 11460

💛 - Coveralls

@hustcc hustcc merged commit ed3047e into master May 31, 2021
@hustcc hustcc deleted the legend-marker branch May 31, 2021 06:03
@visiky visiky mentioned this pull request Jun 2, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants