Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): 主题 Token #3361

Merged
merged 6 commits into from
Apr 21, 2021
Merged

feat(theme): 主题 Token #3361

merged 6 commits into from
Apr 21, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Apr 6, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

image

  • 提供连续色板配置。增加 sequenceColors 配置,styleSheet 提供 paletteSequence (适用于色块图、仪表盘等)
  • scrollbar 支持切换浅色、深色主题。增加 scrollbar 若干 token
  • slider 支持切换浅色、深色主题。增加 slider 若干 token
  • 增加 subColor
Before After
image image
image
浅色的副背景色 image 深色的副背景色 image

@coveralls
Copy link

coveralls commented Apr 6, 2021

Pull Request Test Coverage Report for Build 743995631

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 93.551%

Totals Coverage Status
Change from base Build 743742278: 0.04%
Covered Lines: 10925
Relevant Lines: 11323

💛 - Coveralls

@visiky visiky requested review from hustcc and simaQ April 7, 2021 02:03
@hustcc
Copy link
Member

hustcc commented Apr 7, 2021

sequenceColors 的含义就是离散的,你要加的应该是属于连续的色板,或者渐变色板

@visiky
Copy link
Member Author

visiky commented Apr 7, 2021

sequenceColors 的含义就是离散的,你要加的应该是属于连续的色板,或者渐变色板

可我想强调的就是连续色板,而不是渐变色板;渐变需要自己去做连接

@visiky visiky changed the title feat(theme): 主题提供连续色板配置 wip: feat(theme): 主题 Token Apr 7, 2021
@pr-triage pr-triage bot removed the PR: unreviewed label Apr 7, 2021
@visiky
Copy link
Member Author

visiky commented Apr 7, 2021

问题1: 连续色板的命名
问题2: slider 缩略轴组件的命名。目前被连续图例所占用,如下:
[x] 解决方案:slider 组件,使用 cSlider 命名

  /** 连续图例滑块填充色 */
  sliderRailFillColor?: string;
  /** 连续图例滑块边框粗细 */
  sliderRailBorder?: number;
  /** 连续图例滑块边框颜色 */
  sliderRailBorderColor?: string;
  /** 连续图例滑块宽度 */
  sliderRailWidth?: number;
  /** 连续图例滑块高度 */
  sliderRailHeight?: number;

  /** 连续图例文本颜色 */
  sliderLabelTextFillColor?: string;
  /** 连续图例文本字体大小 */
  sliderLabelTextFontSize?: number;
  /** 连续图例文本行高 */
  sliderLabelTextLineHeight?: number;
  /** 连续图例文本字体粗细 */
  sliderLabelTextFontWeight?: number | string;

  /** 连续图例滑块颜色 */
  sliderHandlerFillColor?: string;
  /** 连续图例滑块宽度 */
  sliderHandlerWidth?: number;
  /** 连续图例滑块高度 */
  sliderHandlerHeight?: number;
  /** 连续图例滑块边框粗细 */
  sliderHandlerBorder?: number;
  /** 连续图例滑块边框颜色 */
  sliderHandlerBorderColor?: string;

@visiky visiky changed the title wip: feat(theme): 主题 Token feat(theme): 主题 Token Apr 13, 2021
@hustcc hustcc merged commit 182c68a into master Apr 21, 2021
@hustcc hustcc deleted the theme-upgrade branch April 21, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants