Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip animation if fromPath equals toPath #6193

Merged
merged 4 commits into from
Apr 23, 2024
Merged

fix: skip animation if fromPath equals toPath #6193

merged 4 commits into from
Apr 23, 2024

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Apr 23, 2024 •
edited by pearmini
Loading

close #6179
Skip applying animation if fromPath equals toPath in oneToOne morphing effect.

close #6190
Create a clipPath shared between all elements in brushHighlight interaction.
截屏2024-04-23 下午2 20 00

@xiaoiver xiaoiver requested a review from pearmini April 23, 2024 05:05
@coveralls
Copy link

coveralls commented Apr 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8795868159

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 86.375%
Totals Coverage Status
Change from base Build 8777551306: 0.003%
Covered Lines: 10296
Relevant Lines: 11547
💛 - Coveralls

pearmini
pearmini approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

高效啊！

@pearmini pearmini merged commit fee3397 into v5 Apr 23, 2024
2 checks passed
@pearmini pearmini deleted the fix-6179 branch April 23, 2024 07:02
@xiaoiver xiaoiver mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@xiaoiver @coveralls @pearmini