-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to [email protected] for better performance #6149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
这个图形用 G2 的 beta 版本会出现问题。https://observablehq.com/d/f404e5b5f5382392?collection=@antv/cases-of-interesting-visualization |
规范了下属性名和 SVG 保持一致。Path 的路径定义属性应该是 d const p = document.createElement('path', {
style: {
d: path, // 这里属性名改成 d 就好了
inset: 1,
fill: value.color,
},
}); |
截图问题都已经修复,CI 测试用例都过了,但构建会报错(本地正常):
|
hustcc
reviewed
Apr 8, 2024
pearmini
approved these changes
Apr 8, 2024
This was referenced Apr 22, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
升级到
@antv/[email protected]
https://github.com/antvis/G/releases/tag/%40antv%2Fg%406.0.0
主要修改包括:
x/y
改为transform
表示path
->d
titleTransform
调整到之前同样的位置runtime.enableCSSParsing = false;
现默认开启circle
和hollowCircle
用于绘制较高性能的散点图之前版本遗留 bug 修复和 hack 写法移除:
scale(1, 1) translate(0, 0)
用于配平对比截图目前不一致:
性能对比
例子太多有些卡甚至页面崩溃,拆分成多个 OB 文档