Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transform): add pack padding and direction #5964

Merged
merged 4 commits into from
Dec 21, 2023
Merged

feat(transform): add pack padding and direction #5964

merged 4 commits into from
Dec 21, 2023

Conversation

Runtus
Copy link
Contributor

@Runtus Runtus commented Dec 21, 2023 •
edited by pearmini
Loading

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change
  • 增加单元可视化的两个新设置：padding and direction.
  • padding用于指定两元素之间的距离。
  • direction用于指定堆叠方向。

close #5875

@Runtus Runtus mentioned this pull request Dec 21, 2023
Closed
pearmini
pearmini requested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一个小的可以优化的点 🤣

src/runtime/plot.ts Outdated Show resolved Hide resolved
@pearmini pearmini mentioned this pull request Dec 21, 2023
Closed
pearmini
pearmini approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

牛逼 👍

@pearmini pearmini merged commit 082606c into antvis:v5 Dec 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More options on pack transform
2 participants
@Runtus @pearmini