Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundle sideEffects config #5603

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: bundle sideEffects config #5603

merged 1 commit into from
Sep 27, 2023

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Sep 27, 2023

前一个分支的构建,因为没有注意到 sideEffects,导致构建出来的 bundle 文件中,下面的代码被移除。

import { runtime } from '@antv/g';
runtime.enableCSSParsing = false;

带来了一些渲染问题。

@hustcc hustcc requested a review from pearmini September 27, 2023 02:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6320803199

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.199%

Totals Coverage Status
Change from base Build 6320375459: 0.0%
Covered Lines: 10022
Relevant Lines: 11004

💛 - Coveralls

@pearmini pearmini merged commit dbbedfe into v5 Sep 27, 2023
2 checks passed
@pearmini pearmini deleted the fix-bundle-error branch September 27, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants