-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: labelFilter 参数与 labelFormatter 保持一致 #4911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pearmini
requested changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 加一个单测测一下 tickFilter?
- commit 英文
Aarebecca
force-pushed
the
fix/fix-axis-filter
branch
from
April 24, 2023 11:28
cbcf16c
to
55e2be8
Compare
pearmini
changed the title
fix: labelFilter 参数与 labelFormatter保持一致
fix: labelFilter 参数与 labelFormatter 保持一致
Apr 24, 2023
文档需要更新吗? |
pearmini
approved these changes
Apr 25, 2023
fix #4909 |
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
* fix: refactor labelFilter to has same pramameters with labelFormatter * test: add test case
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
* fix: refactor labelFilter to has same pramameters with labelFormatter * test: add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主要是对用户传入的 labelFormatter 和 labelFilter 做了层包装