Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: labelFilter 参数与 labelFormatter 保持一致 #4911

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Conversation

Aarebecca
Copy link
Contributor

主要是对用户传入的 labelFormatter 和 labelFilter 做了层包装

image

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 加一个单测测一下 tickFilter?
  • commit 英文

@Aarebecca Aarebecca force-pushed the fix/fix-axis-filter branch from cbcf16c to 55e2be8 Compare April 24, 2023 11:28
@pearmini pearmini changed the title fix: labelFilter 参数与 labelFormatter保持一致 fix: labelFilter 参数与 labelFormatter 保持一致 Apr 24, 2023
@hustcc
Copy link
Member

hustcc commented Apr 25, 2023

文档需要更新吗?

@hustcc hustcc merged commit f96b2f4 into v5 Apr 25, 2023
@hustcc hustcc deleted the fix/fix-axis-filter branch April 25, 2023 06:20
@pearmini
Copy link
Member

fix #4909

hustcc pushed a commit that referenced this pull request May 16, 2023
* fix: refactor labelFilter to has same pramameters with labelFormatter

* test: add test case
hustcc pushed a commit that referenced this pull request May 16, 2023
* fix: refactor labelFilter to has same pramameters with labelFormatter

* test: add test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants