Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(interval): fix interval render funnel (#4868) #4875

Merged
merged 3 commits into from
Apr 11, 2023
Merged

fix(interval): fix interval render funnel (#4868) #4875

merged 3 commits into from
Apr 11, 2023

Conversation

shield2018
Copy link
Contributor

修复interval绘制funnel、pyramid

@hustcc
Copy link
Member

hustcc commented Apr 7, 2023

非常感谢贡献，PR 描述中写一下当前的问题和你的解法方案吧，有助于 CR 以及大家了解这个 PR。@shield2018

@pearmini
Copy link
Member

pearmini commented Apr 7, 2023 •
edited
Loading

非常感谢贡献，PR 描述中写一下当前的问题和你的解法方案吧，有助于 CR 以及大家了解这个 PR。@shield2018

@hustcc 这里有个相关的 #4868

hustcc
hustcc requested changes Apr 7, 2023
View reviewed changes
src/shape/interval/color.ts Outdated Show resolved Hide resolved
@shield2018
Copy link
Contributor Author

麻烦关注一下
#4877

这个bug会导致漏斗图点击图例后，4个点的计算出现问题

pearmini
pearmini requested changes Apr 11, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该需要更新一下截图，代码里面的 maker 是 square：

@shield2018
Copy link
Contributor Author

这里应该需要更新一下截图，代码里面的 maker 是 square：

done

@hustcc hustcc merged commit 0856113 into antvis:v5 Apr 11, 2023
hustcc pushed a commit that referenced this pull request May 16, 2023
@shield2018 @hustcc
fix(interval): fix interval render funnel (#4868) (#4875)
a7ed4e9 
* fix(interval): fix interval render funnel (#4868)

* fix(interval): fix funnel and pyramid props

* fix(interval): update funnel snapshot

---------

Co-authored-by: shield2018 <>
hustcc pushed a commit that referenced this pull request May 16, 2023
@shield2018 @hustcc
fix(interval): fix interval render funnel (#4868) (#4875)
1e328b7 
* fix(interval): fix interval render funnel (#4868)

* fix(interval): fix funnel and pyramid props

* fix(interval): update funnel snapshot

---------

Co-authored-by: shield2018 <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shield2018 @hustcc @pearmini