Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): wait for the next tick to finish rendering (close: #4771) #4855

Merged
merged 2 commits into from
Apr 3, 2023
Merged

fix(runtime): wait for the next tick to finish rendering (close: #4771) #4855

merged 2 commits into from
Apr 3, 2023

Conversation

pearmini
Copy link
Member

@pearmini pearmini commented Mar 31, 2023 •
edited
Loading

修复这里提到的问题：#4771

  • 通过 g canvas 的 requestAnimationFrame 确保在浏览器绘制下一帧的时候抛出结束渲染的事件。这样服务端渲染的时候就不用显示调用 sleep(20) 等待渲染完成了。
  • 之前的截图有缺失，更新正确的截图。

image

@pearmini pearmini force-pushed the feat/missing-frame branch from 3386405 to d1cafc8 Compare March 31, 2023 10:34
@pearmini pearmini requested review from Aarebecca and xiaoiver April 3, 2023 03:12
pepper-nice
pepper-nice reviewed Apr 3, 2023
View reviewed changes
src/runtime/render.ts Outdated Show resolved Hide resolved
xiaoiver
xiaoiver requested changes Apr 3, 2023
View reviewed changes
src/runtime/render.ts Outdated Show resolved Hide resolved
@pearmini pearmini force-pushed the feat/missing-frame branch from fe453fa to 33506fd Compare April 3, 2023 07:06
@pearmini pearmini merged commit 1ec5d0e into v5 Apr 3, 2023
@pearmini pearmini deleted the feat/missing-frame branch April 3, 2023 07:55
hustcc pushed a commit that referenced this pull request May 16, 2023
@pearmini @hustcc
fix(runtime): wait for the next tick to finish rendering (close: #4771)…
9fb0b08 
… (#4855)

* fix(runtime): wait for the next tick to finish rendering (close: #4771)

* fix: cr
hustcc pushed a commit that referenced this pull request May 16, 2023
@pearmini @hustcc
fix(runtime): wait for the next tick to finish rendering (close: #4771)…
00815aa 
… (#4855)

* fix(runtime): wait for the next tick to finish rendering (close: #4771)

* fix: cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepper-nice pepper-nice pepper-nice left review comments

@xiaoiver xiaoiver xiaoiver approved these changes

@Aarebecca Aarebecca Awaiting requested review from Aarebecca

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pearmini @xiaoiver @pepper-nice