Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 tooltipsummary 组件 的 总和 前后括号不一致, 期望跟vue组件一致,不渲染前后括号 #2440

Closed
1 of 5 tasks
xulingling0 opened this issue Dec 1, 2023 · 4 comments · Fixed by #2442

Comments

@xulingling0
Copy link

xulingling0 commented Dec 1, 2023

🏷 Version

Package Version
@antv/s2
@antv/s2-react 1.44.2
@antv/s2-vue

Sheet Type

  • PivotSheet
  • TableSheet
  • GridAnalysisSheet
  • StrategySheet
  • EditableSheet

🖋 Description

image 现状:左括号用的是双字节(中文括号),右括号用的是单字节(英文括号)

期望:跟vue 组件保持一致, “总和”左右两边的括号应该不渲染。

⌨️ Code Snapshots

源代码地址: https://github.com/antvis/S2/blob/master/packages/s2-react/src/components/tooltip/components/summary.tsx

return (
       <div
         key={`${name}-${value}`}
         className={`${TOOLTIP_PREFIX_CLS}-summary-item`}
       >
         {name ? (
           <span className={`${TOOLTIP_PREFIX_CLS}-summary-key`}>
             {name} {i18n('总和')})
           </span>
         ) : (
       </div>
    );

vue版本:

   <span :class="`${TOOLTIP_PREFIX_CLS}-summary-key`">
     {{ summary.name }} {{ i18n('总和') }}
   </span>

🔗 Reproduce Link

https://s2.antv.antgroup.com/zh/examples/react-component/sheet/#pivot (官方demo, 不需要任何改动)

🤔 Steps to Reproduce

点击 数量 等任意分类,出现弹窗,找到总和,观察前后括号

😊 Expected Behavior

😅 Current Behavior

💻 System information

Environment Info
System all
Browser all
@xulingling0 xulingling0 changed the title 🐛 tooltipsummary 组件 的 总和 前后括号不一致,希望保持一致并且可支持多语言配置 🐛 tooltipsummary 组件 的 总和 前后括号不一致,希望前后括号保持一致并且可支持多语言配置 Dec 1, 2023
@xulingling0 xulingling0 changed the title 🐛 tooltipsummary 组件 的 总和 前后括号不一致,希望前后括号保持一致并且可支持多语言配置 🐛 tooltipsummary 组件 的 总和 前后括号不一致, 期望跟vue组件一致,不渲染前后括号 Dec 1, 2023
@lijinke666
Copy link
Member

🎉 This issue has been resolved in version @antv/s2-v1.52.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This issue has been resolved in version @antv/s2-react-v1.44.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This issue has been resolved in version @antv/s2-v1.53.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This issue has been resolved in version @antv/s2-react-v1.45.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants