Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 2k 显示器切换到 MacBook 后表格渲染模糊 close #2072 #2074

Merged
merged 5 commits into from
Feb 14, 2023

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Feb 13, 2023

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

📝 Description

背景见 #2072

原因: 我们通过 matchMedia 监听设备 DPR 的改变来做高清渲染, 通过 visualViewportresize 来监听Mac 触摸板双指缩放, DPR改变时 resize 事件也会触发 (在 matchMedia) 之后, 导致 DPR 从 1 => 2 => 1 , 多渲染了一次

🖼️ Screenshot

放大查看更明显

Before After
Kapture 2023-02-13 at 20 07 20 Kapture 2023-02-13 at 20 05 24
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
antvis-s2 ❌ Failed (Inspect) Feb 14, 2023 at 8:28AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023

Size Change: +44 B (0%)

Total Size: 435 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 171 kB +44 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js 21.7 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js 21.2 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js 60.3 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js 33.9 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/config.js 1.16 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js 1.87 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js 1.18 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/events.js 1.55 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js 300 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js 738 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js 810 B
./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js 1.07 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/index.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js 1.05 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js 1.47 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js 337 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js 573 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js 713 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js 418 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js 1.8 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js 491 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js 2.67 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js 498 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js 958 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js 718 B
./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js 1.81 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js 2.82 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js 1.51 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js 1.5 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js 748 B
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js 2.38 kB
./packages/s2-react/dist/index.min.js 67.4 kB
./packages/s2-react/dist/style.min.css 3.43 kB
./packages/s2-vue/dist/index.min.js 20.5 kB
./packages/s2-vue/dist/style.min.css 1.68 kB

compressed-size-action

@lijinke666 lijinke666 changed the title fix: 修复 2k 显示器切换到 MacBook 后表格渲染模糊 close #2072 [WIP] fix: 修复 2k 显示器切换到 MacBook 后表格渲染模糊 close #2072 Feb 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added 🚨 test failed 单元测试挂了 and removed pr(fix) bug fix labels Feb 13, 2023
@lijinke666 lijinke666 changed the title [WIP] fix: 修复 2k 显示器切换到 MacBook 后表格渲染模糊 close #2072 fix: 修复 2k 显示器切换到 MacBook 后表格渲染模糊 close #2072 Feb 14, 2023
@github-actions github-actions bot added the pr(fix) bug fix label Feb 14, 2023
@lijinke666 lijinke666 enabled auto-merge (squash) February 14, 2023 08:40
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 77.16% // Head: 76.59% // Decreases project coverage by -0.57% ⚠️

Coverage data is based on head (9126f75) compared to base (a4b14a8).
Patch coverage: 67.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
- Coverage   77.16%   76.59%   -0.57%     
==========================================
  Files         234      240       +6     
  Lines       11518    12238     +720     
  Branches     2449     2606     +157     
==========================================
+ Hits         8888     9374     +486     
- Misses       1258     1366     +108     
- Partials     1372     1498     +126     
Impacted Files Coverage Δ
packages/s2-core/src/cell/merged-cell.ts 34.78% <ø> (-1.59%) ⬇️
packages/s2-core/src/common/constant/index.ts 90.47% <ø> (-0.60%) ⬇️
packages/s2-core/src/data-set/base-data-set.ts 93.54% <ø> (+25.80%) ⬆️
packages/s2-core/src/facet/header/row.ts 85.18% <0.00%> (ø)
...kages/s2-core/src/interaction/row-column-resize.ts 86.53% <0.00%> (ø)
packages/s2-core/src/sheet-type/pivot-sheet.ts 86.11% <0.00%> (ø)
packages/s2-core/src/sheet-type/table-sheet.ts 89.65% <ø> (+1.72%) ⬆️
packages/s2-core/src/ui/hd-adapter/index.ts 0.00% <0.00%> (ø)
packages/s2-core/src/utils/hide-columns.ts 83.87% <ø> (+0.35%) ⬆️
packages/s2-core/src/utils/interaction/index.ts 95.23% <ø> (+0.59%) ⬆️
... and 163 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lijinke666 lijinke666 merged commit a98d3fd into master Feb 14, 2023
@lijinke666 lijinke666 deleted the fix-hd branch February 14, 2023 10:04
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v1.41.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
* fix: 修复 2k 显示器切换到 MacBook 后表格渲染模糊 close #2072

* test: 增加测试

* test: 修复高清测试

* test: 修复测试

* test: 修复测试
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 外接显示器拖到 MacBook 表格渲染模糊
2 participants