Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 增加自定义行头最大固定宽度的功能 #2069

Merged
merged 7 commits into from
Feb 17, 2023
Merged

Conversation

wjgogogo
Copy link
Contributor

@wjgogogo wjgogogo commented Feb 9, 2023

👀 PR includes

✨ Feature

📝 Description

  1. 移除 isScrollContainsRowHeader 相关方法,该方法本质上就是对 isFrozenRowHeader 取反,稍显冗余
  2. 扩展 frozen.rowHeader 支持类型,通过支持 number 实现自定义最大固定宽度的能力

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel
Copy link

vercel bot commented Feb 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
antvis-s2 ❌ Failed (Inspect) Feb 17, 2023 at 9:09AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Size Change: -22 B (0%)

Total Size: 317 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 224 kB -22 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-react/dist/index.min.js 66.7 kB
./packages/s2-react/dist/style.min.css 3.63 kB
./packages/s2-vue/dist/index.min.js 20.2 kB
./packages/s2-vue/dist/style.min.css 1.79 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

你好, @wjgogogo CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @wjgogogo CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 75.77% // Head: 76.24% // Increases project coverage by +0.47% 🎉

Coverage data is based on head (987ce7f) compared to base (ecdc9c8).
Patch coverage: 79.64% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2069      +/-   ##
==========================================
+ Coverage   75.77%   76.24%   +0.47%     
==========================================
  Files         257      262       +5     
  Lines       11994    11875     -119     
  Branches     2464     2437      -27     
==========================================
- Hits         9088     9054      -34     
+ Misses       1398     1346      -52     
+ Partials     1508     1475      -33     
Impacted Files Coverage Δ
packages/s2-core/src/cell/merged-cell.ts 37.50% <ø> (ø)
packages/s2-core/src/cell/table-col-cell.ts 80.76% <0.00%> (-0.37%) ⬇️
...ckages/s2-core/src/common/constant/events/basic.ts 100.00% <ø> (ø)
packages/s2-core/src/common/constant/options.ts 100.00% <ø> (ø)
packages/s2-core/src/common/constant/total.ts 100.00% <ø> (ø)
packages/s2-core/src/common/debug/index.ts 76.00% <ø> (ø)
packages/s2-core/src/common/i18n/index.ts 85.71% <ø> (-0.65%) ⬇️
packages/s2-core/src/common/store/index.ts 88.88% <ø> (ø)
packages/s2-core/src/data-set/cell-data.ts 73.68% <ø> (ø)
...s2-core/src/data-set/custom-tree-pivot-data-set.ts 100.00% <ø> (ø)
... and 252 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lijinke666 lijinke666 added the next 2.0-next 版本的问题 label Feb 13, 2023
@wjgogogo wjgogogo merged commit 4db301d into next Feb 17, 2023
@wjgogogo wjgogogo deleted the feat-2024 branch February 17, 2023 09:49
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v2.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(feature) new feature released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants