Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): 修复树状模式下无列头时行头对应的角头不显示 #2041

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Jan 10, 2023

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

#2026 这个 PR 中, 修复了无列头时行头对应的角头不显示, 但只考虑了平铺模式, 还需要兼容树状模式开启序号的场景

🖼️ Screenshot

Before After
image image
image image
image image

🔗 Related issue link

ref #2026

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel
Copy link

vercel bot commented Jan 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
antvis-s2 ❌ Failed (Inspect) Jan 13, 2023 at 10:03AM (UTC)

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 77.16% // Head: 76.65% // Decreases project coverage by -0.51% ⚠️

Coverage data is based on head (c0db74d) compared to base (a4b14a8).
Patch coverage: 66.63% of modified lines in pull request are covered.

❗ Current head c0db74d differs from pull request most recent head 1eb8f60. Consider uploading reports for the commit 1eb8f60 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2041      +/-   ##
==========================================
- Coverage   77.16%   76.65%   -0.52%     
==========================================
  Files         234      240       +6     
  Lines       11518    12230     +712     
  Branches     2449     2605     +156     
==========================================
+ Hits         8888     9375     +487     
- Misses       1258     1362     +104     
- Partials     1372     1493     +121     
Impacted Files Coverage Δ
packages/s2-core/src/cell/merged-cell.ts 34.78% <ø> (-1.59%) ⬇️
packages/s2-core/src/common/constant/index.ts 90.47% <ø> (-0.60%) ⬇️
packages/s2-core/src/common/icons/gui-icon.ts 86.66% <ø> (-1.71%) ⬇️
packages/s2-core/src/data-set/base-data-set.ts 93.54% <ø> (+25.80%) ⬆️
packages/s2-core/src/facet/header/row.ts 85.18% <0.00%> (ø)
packages/s2-core/src/facet/layout/node.ts 65.16% <ø> (+2.81%) ⬆️
...kages/s2-core/src/interaction/row-column-resize.ts 86.53% <0.00%> (ø)
packages/s2-core/src/sheet-type/pivot-sheet.ts 86.11% <0.00%> (ø)
packages/s2-core/src/sheet-type/table-sheet.ts 89.65% <ø> (+1.72%) ⬆️
packages/s2-core/src/utils/hide-columns.ts 83.87% <ø> (+0.35%) ⬆️
... and 165 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023

Size Change: -43 B (0%)

Total Size: 435 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 171 kB -43 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js 21.7 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js 21.2 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js 60.3 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js 33.9 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/config.js 1.16 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js 1.87 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js 1.18 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/events.js 1.55 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js 300 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js 738 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js 810 B
./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js 1.07 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/index.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js 1.05 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js 1.47 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js 337 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js 573 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js 713 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js 418 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js 1.8 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js 491 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js 2.67 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js 498 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js 958 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js 718 B
./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js 1.81 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js 2.82 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js 1.51 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js 1.5 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js 748 B
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js 2.38 kB
./packages/s2-react/dist/index.min.js 67.4 kB
./packages/s2-react/dist/style.min.css 3.43 kB
./packages/s2-vue/dist/index.min.js 20.5 kB
./packages/s2-vue/dist/style.min.css 1.68 kB

compressed-size-action

@lijinke666 lijinke666 enabled auto-merge (squash) January 13, 2023 08:04
@lijinke666 lijinke666 merged commit 1b49667 into master Jan 13, 2023
@lijinke666 lijinke666 deleted the fix-corner-tree branch January 13, 2023 10:37
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v1.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants