Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 基础表、趋势分析表tooltip新增显示字段说明功能 #1541

Merged
merged 5 commits into from
Jul 8, 2022
Merged

feat: 基础表、趋势分析表tooltip新增显示字段说明功能 #1541

merged 5 commits into from
Jul 8, 2022

Conversation

GaoFuhong
Copy link
Contributor

👀 PR includes

✨ Feature

✅ New feature

📝 Description

  1. 给基础表tooltip添加字段说明：

Kapture 2022-07-07 at 17 28 31

  1. 给趋势分析表单元格tooltip添加字段说明：

20220707200439

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@github-actions github-actions bot added the pr(feature) new feature label Jul 7, 2022
@lijinke666
Copy link
Member

解决下冲突, rebase 下 master

@GaoFuhong GaoFuhong force-pushed the feat-tooltip-description branch from b53e6fb to 0170510 Compare July 8, 2022 03:39
@wjgogogo wjgogogo changed the title feat: 给基础表、趋势分析表tooltip新增显示字段说明功能 feat: 基础表、趋势分析表tooltip新增显示字段说明功能 Jul 8, 2022
@GaoFuhong GaoFuhong force-pushed the feat-tooltip-description branch from fcc4efc to 2a07246 Compare July 8, 2022 05:20
lijinke666
lijinke666 previously approved these changes Jul 8, 2022
View reviewed changes
lijinke666
lijinke666 previously approved these changes Jul 8, 2022
View reviewed changes
@lijinke666 lijinke666 enabled auto-merge (squash) July 8, 2022 06:13
@lgtm-com
Copy link

lgtm-com bot commented Jul 8, 2022

This pull request introduces 1 alert when merging 5c231f4 into b44ffe3 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022 •
edited
Loading

你好, @GaoFuhong CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @GaoFuhong CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Jul 8, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jul 8, 2022

This pull request introduces 1 alert when merging 67188b7 into b44ffe3 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lijinke666 lijinke666 merged commit 3a9f3cb into master Jul 8, 2022
@lijinke666 lijinke666 deleted the feat-tooltip-description branch July 8, 2022 09:27
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Jul 8, 2022
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-react-v1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Jul 8, 2022
@lcx-seima lcx-seima mentioned this pull request Jul 10, 2022
Merged
2 tasks
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v1.23.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-react-v1.21.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
@GaoFuhong @stone-lyl
feat: 基础表、趋势分析表tooltip新增显示字段说明功能 (#1541)
88bed8d 
* feat: 给基础表、趋势分析表tooltip新增显示字段说明功能

* refactor: 优化tooltip字段说明部分代码

* fix: rename

Co-authored-by: stone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjgogogo wjgogogo wjgogogo left review comments

@lijinke666 lijinke666 lijinke666 approved these changes

@lcx-seima lcx-seima Awaiting requested review from lcx-seima

@qubaomingg qubaomingg Awaiting requested review from qubaomingg

@stone-lyl stone-lyl Awaiting requested review from stone-lyl

@xingwanying xingwanying Awaiting requested review from xingwanying

@YardWill YardWill Awaiting requested review from YardWill

@zxc0328 zxc0328 Awaiting requested review from zxc0328

Assignees

@GaoFuhong GaoFuhong

Labels
pr(feature) new feature released on @alpha released 🚨 test failed 单元测试挂了
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GaoFuhong @lijinke666 @wjgogogo @stone-lyl