Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(strategysheet): 趋势分析表 Tooltip 增加 label 属性用于自定义标题 #1540

Merged
merged 3 commits into from
Jul 8, 2022

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Jul 7, 2022

👀 PR includes

✨ Feature

  • New feature

📝 Description

  1. 将趋势分析表自定义的三个 Tooltip 透出, 业务层可对其进行引用, 而不用完全自定义
  2. 增加 label 属性, 允许自定义标题
   <StrategySheetDataTooltip cell={cell} label={'指标A (求和)'} />

🖼️ Screenshot

image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@lijinke666 lijinke666 changed the title feat(strategysheet): 趋势分析表 Tooltip 增加 label 属性用于自定义标题 [WIP] feat(strategysheet): 趋势分析表 Tooltip 增加 label 属性用于自定义标题 Jul 7, 2022
@github-actions github-actions bot added the pr(feature) new feature label Jul 7, 2022
@github-actions github-actions bot removed the pr(feature) new feature label Jul 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Size Change: +71 B (0%)

Total Size: 252 kB

Filename Size Change
./packages/s2-react/dist/index.min.js 63.7 kB +71 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 163 kB
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-react/dist/style.min.css 3.2 kB
./packages/s2-vue/dist/index.min.js 20.3 kB
./packages/s2-vue/dist/style.min.css 1.59 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Jul 7, 2022
@lijinke666 lijinke666 changed the title [WIP] feat(strategysheet): 趋势分析表 Tooltip 增加 label 属性用于自定义标题 feat(strategysheet): 趋势分析表 Tooltip 增加 label 属性用于自定义标题 Jul 8, 2022
@github-actions github-actions bot added the pr(feature) new feature label Jul 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #1540 (bb9206c) into master (809d919) will increase coverage by 0.64%.
The diff coverage is 73.80%.

@@            Coverage Diff             @@
##           master    #1540      +/-   ##
==========================================
+ Coverage   76.37%   77.01%   +0.64%     
==========================================
  Files         227      229       +2     
  Lines       10856    10952      +96     
  Branches     2244     2292      +48     
==========================================
+ Hits         8291     8435     +144     
+ Misses       1301     1252      -49     
- Partials     1264     1265       +1     
Impacted Files Coverage Δ
packages/s2-core/src/theme/index.ts 100.00% <ø> (ø)
...omponents/sheets/strategy-sheet/custom-col-cell.ts 40.00% <ø> (ø)
packages/s2-core/src/utils/text.ts 40.93% <7.14%> (-0.43%) ⬇️
...act/src/components/sheets/strategy-sheet/index.tsx 65.38% <50.00%> (+34.61%) ⬆️
packages/s2-core/src/cell/col-cell.ts 88.32% <86.95%> (+1.19%) ⬆️
packages/s2-core/src/utils/canvas.ts 87.50% <87.50%> (ø)
packages/s2-core/src/cell/data-cell.ts 67.48% <100.00%> (+2.03%) ⬆️
packages/s2-core/src/facet/base-facet.ts 85.64% <100.00%> (+3.43%) ⬆️
packages/s2-core/src/sheet-type/spread-sheet.ts 81.39% <100.00%> (+0.21%) ⬆️
packages/s2-core/src/utils/cell/cell.ts 74.77% <100.00%> (-0.68%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b47b05...bb9206c. Read the comment docs.

@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Jul 8, 2022
@lijinke666 lijinke666 merged commit b44ffe3 into master Jul 8, 2022
@lijinke666 lijinke666 deleted the tooltip-label branch July 8, 2022 04:40
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v1.21.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
* feat(strategysheet): 趋势分析表 Tooltip 增加 label 属性用于自定义标题

* feat: update

* test: 增加测试
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants