Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drill-down): values 配置为空时未显示下钻 icon #1535

Merged
merged 4 commits into from
Jul 8, 2022

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

  1. values 配置为空时未显示下钻 icon

当 fields.values 为空时, 由于布局限制, 会将 valueInCols 为空

result.fields.valueInCols = false;

而下钻需要置为列头, 导致影响了显示下钻icon的判断

image

  1. 默认的 sort icon 加上 values 不为空的限制

🖼️ Screenshot

Before After
image image

🔗 Related issue link

close #1514

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.
  • [ ]

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Size Change: +74 B (0%)

Total Size: 252 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 163 kB +24 B (0%)
./packages/s2-react/dist/index.min.js 63.6 kB +28 B (0%)
./packages/s2-vue/dist/index.min.js 20.3 kB +22 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-react/dist/style.min.css 3.2 kB
./packages/s2-vue/dist/style.min.css 1.59 kB

compressed-size-action

@stone-lyl
Copy link
Member

如果 isValueInCol 为 true ,且 values 为空。列头会展示排序 icon 吗?

@xingwanying xingwanying enabled auto-merge (squash) July 7, 2022 08:19
@lijinke666
Copy link
Member Author

values 为空, 会强制将 valueInCols 置为 false, 所以这种情况不会有

@xingwanying xingwanying merged commit 8a1d27c into master Jul 8, 2022
@xingwanying xingwanying deleted the fix-drill-down-icon branch July 8, 2022 09:10
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v1.23.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v1.21.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
* fix(drill-down): values 配置为空时未显示下钻 icon

* test: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛s2-vue,s2-react未配置s2DataConfig.fields.values时,不期望列出现排序按钮
3 participants