-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(drill-down): values 配置为空时未显示下钻 icon #1535
Conversation
Size Change: +74 B (0%) Total Size: 252 kB
ℹ️ View Unchanged
|
如果 isValueInCol 为 true ,且 values 为空。列头会展示排序 icon 吗? |
values 为空, 会强制将 valueInCols 置为 false, 所以这种情况不会有 |
🎉 This PR is included in version @antv/s2-v1.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-react-v1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-v1.23.0-alpha.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-react-v1.21.0-alpha.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
* fix(drill-down): values 配置为空时未显示下钻 icon * test: update
👀 PR includes
🐛 Bugfix
🔧 Chore
📝 Description
当 fields.values 为空时, 由于布局限制, 会将 valueInCols 为空
S2/packages/s2-core/src/utils/merge.ts
Line 50 in a92a4b7
而下钻需要置为列头, 导致影响了显示下钻icon的判断
🖼️ Screenshot
🔗 Related issue link
close #1514
🔍 Self-Check before the merge