-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: liquid data is not in object form antvis #6145 #6379
Conversation
Pull Request Test Coverage Report for Build 10052478865Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
非常感谢贡献!🙏
不过,可以参考 __tests__/plots/static/liquid-default.ts
添加一个测试案例,测试一下水波图的数据合并问题:
import { G2Spec } from '../../../src';
export function liquidNumber(): G2Spec {
return {
type: 'view',
data: 0.3,
children: [{ type: 'liquid' }],
};
}
liquidNumber.skip = true;
运行 npm run dev
确保对应案例没有问题。
好的,感谢提供思路。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
修复liquid data不是{value:data}形式显示NaN问题。