Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: liquid data is not in object form antvis #6145 #6379

Merged
merged 13 commits into from
Jul 23, 2024
Merged

Conversation

the-lemonboy
Copy link
Contributor

修复liquid data不是{value:data}形式显示NaN问题。
image

src/composition/utils.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 22, 2024

Pull Request Test Coverage Report for Build 10052478865

Details

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 86.665%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/composition/utils.ts 6 7 85.71%
Totals Coverage Status
Change from base Build 10039688722: -0.007%
Covered Lines: 10530
Relevant Lines: 11773

💛 - Coveralls

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常感谢贡献!🙏

不过,可以参考 __tests__/plots/static/liquid-default.ts 添加一个测试案例,测试一下水波图的数据合并问题:

import { G2Spec } from '../../../src';

export function liquidNumber(): G2Spec {
  return {
    type: 'view',
    data: 0.3,
    children: [{ type: 'liquid' }],
  };
}

liquidNumber.skip = true;

运行 npm run dev 确保对应案例没有问题。

src/composition/utils.ts Outdated Show resolved Hide resolved
@the-lemonboy
Copy link
Contributor Author

非常感谢贡献!🙏

不过,可以参考 __tests__/plots/static/liquid-default.ts 添加一个测试案例,测试一下水波图的数据合并问题:

import { G2Spec } from '../../../src';

export function liquidNumber(): G2Spec {
  return {
    type: 'view',
    data: 0.3,
    children: [{ type: 'liquid' }],
  };
}

liquidNumber.skip = true;

运行 npm run dev 确保对应案例没有问题。

好的,感谢提供思路。

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@pearmini pearmini merged commit 1aabab7 into antvis:v5 Jul 23, 2024
2 checks passed
@pearmini pearmini mentioned this pull request Jul 24, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants