Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add avatar visibility option #19

Merged

Conversation

BerniWittmann
Copy link
Contributor

Gives users the option to hide or show the avatar

Gives users the option to hide or show the avatar
@antonreshetov
Copy link
Owner

I think I already answered that question #16

@BerniWittmann
Copy link
Contributor Author

BerniWittmann commented Jan 8, 2019

@antonreshetov #16 was a new template and you answered, that you want to implement it as an option for all templates. This is also stated in the Github Project Card.

So i came up with this PR, which adds an option to hide the avatar and is not a new template

@antonreshetov
Copy link
Owner

@BerniWittmann
I mean, I'm going to implement it. What I actually doing, I have locally there is a branch and the rough work on this.

Well, not to lose your work. Let's make some adjustments

Avatar is enabled by default. Accordingly, the Avatar Visibility option must have the switch already enabled.

Rename Avatar Visibility => Avatar and remove labels from the switch

@BerniWittmann
Copy link
Contributor Author

Whatever 😃 just feel free to do what you want with it (including dropping these changes)

@antonreshetov
Copy link
Owner

antonreshetov commented Jan 8, 2019

Need to be sensitive to someone else's work, so I just adjusted yours. :)

@antonreshetov antonreshetov added the enhancement New feature or request label Jan 8, 2019
@antonreshetov
Copy link
Owner

@BerniWittmann please adjust the PR so I can merge it

@antonreshetov antonreshetov self-requested a review January 9, 2019 06:38
@antonreshetov antonreshetov merged commit 1cb7ce8 into antonreshetov:master Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants