Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Suppress duplicate error messages in terraform_validate #577

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix: Suppress duplicate error messages in terraform_validate #577

merged 2 commits into from
Oct 11, 2023

Conversation

MaxymVlasov
Copy link
Collaborator

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

Description of your changes

Fixes #557

How can we test changes

Do #557 (comment)

but with

repos:
    - repo: https://github.com/antonbabenko/pre-commit-terraform
      rev: d7cc11f0184aaddf67ccaf72a22e9d4b486beffb
      hooks:
          - id: terraform_validate
            args:
                - --args=-no-color

@MaxymVlasov MaxymVlasov added estimate/1h Need 1 hour to be done hook/terraform_validate Bash hook labels Oct 10, 2023
@MaxymVlasov MaxymVlasov changed the title fix(GH-557): Suppress duplicate error mesagges in terraform_validate fix(GH-557): Suppress duplicate error messages in terraform_validate Oct 10, 2023
@MaxymVlasov @yermulnik
Apply suggestions from code review
b4fc247 
Co-authored-by: George L. Yermulnik <[email protected]>
@antonbabenko antonbabenko changed the title fix(GH-557): Suppress duplicate error messages in terraform_validate fix: Suppress duplicate error messages in terraform_validate Oct 10, 2023
@MaxymVlasov MaxymVlasov merged commit 4ea6b14 into master Oct 11, 2023
6 checks passed
@MaxymVlasov MaxymVlasov deleted the fix/GH-557 branch October 11, 2023 11:57
antonbabenko pushed a commit that referenced this pull request Oct 11, 2023
@semantic-release-bot
chore(release): version 1.83.5 [skip ci]
72c60ac 
## [1.83.5](v1.83.4...v1.83.5) (2023-10-11)

### Bug Fixes

* Suppress duplicate error messages in `terraform_validate` ([#577](#577)) ([4ea6b14](4ea6b14))
@antonbabenko
Copy link
Owner

This PR is included in version 1.83.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yermulnik yermulnik yermulnik approved these changes

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
estimate/1h Need 1 hour to be done hook/terraform_validate Bash hook
Projects
None yet
Milestone
Features implementing and cleanup wit...
Development

Successfully merging this pull request may close these issues.

The terraform_validate hook seems to be generating duplicate output
3 participants
@MaxymVlasov @antonbabenko @yermulnik