feat: Speedup terraform_validate - firstly try run validate without checking is .terraform/ is valid
#524
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Is there anything i can to to help get this merged :)? |
|
@yermulnik please review |
MaxymVlasov
changed the title
terraform_validate - firstly try run validate without checking is .terraform/ is valid
MaxymVlasov
added
feature
|
@smelchior Sorry for delay |
# [1.81.0](v1.80.0...v1.81.0) (2023-06-12) ### Features * Speedup `terraform_validate` - firstly try run validate without checking is `.terraform/` is valid ([#524](#524)) ([d0d08ac](d0d08ac))
|
This PR is included in version 1.81.0 🎉 |
|
Thanks for merging this! That makes my life a lot easier :)! |
|
is this supposed to output an error? When I run pre-commit now, it looks like theres an error but then it says it was able to init successfully even on repeat back-to-back executions 
|
|
@bryantbiggs I think it is expected behavior since there are recoverable errors. After it runs, there should be no errors and it should "pass". |
|
yes I'm seeing that now as well - I guess its just when it finds errors that need to be fixed that it shows that output but once all pre-commit checks are passing they are gone and its green. thanks, sorry for the noise! |
|
We can add |
|
I can't reproduce. In any case, open a issue in case you'll need anything |
Put an
xinto the box if that apply:Description of your changes
As discussed in #509 (comment) i would like to introduce a change to run terraform validate in the hook first without running the checks if terraform init is needed.
This helps in situations where there is no
.terraform/modulesor.terraform/providersdirectory as terraform init would be called every time.How can we test changes
Run the terraform_validate.sh hook against your test repositories, if
terraform validateshould run first without any additional checks. If it fails, the normal workflow continues.