-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH Actions which will build Dockerfile if updated #291
Comments
Hey, can I work on this? |
Sure, @mohitsaxenaknoldus ! |
Where can I find the smoke tests? |
If you write them and populate them somewhere in the For now, we have only some kind of performance tests |
So I also have to create the smoke tests as well then? |
Yep |
I've added workflow which will build the Dockerfile if it was changed but I've never worked with smoke tests before :( |
Here's the work so far: #318 |
Maybe we already have the simplest optimistic smoke test here: pre-commit-terraform/Dockerfile Lines 129 to 141 in c5f2a61
@antonbabenko do you'd like to have pre-commit run on some predefined code for each hook? Or what do you mean by "smoke test"? |
I think the simplest optimistic smote test you refer to is a pretty accurate definition of what I meant by "smoke test" :) |
This issue has been resolved in version 1.63.0 🎉 |
GH Actions for pull-requests which runs
docker build
whenDockerfile
changes and run the smoke test?No need to push it to GHCR but just getting versions should be enough. Similar to this one - https://github.com/antonbabenko/pre-commit-terraform/blob/master/.github/workflows/build-image.yaml
Originally posted by @antonbabenko in #288 (comment)
The text was updated successfully, but these errors were encountered: