Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default config of terraform_docs fails #148

Closed
rgevaert opened this issue Sep 16, 2020 · 4 comments · Fixed by #150
Closed

default config of terraform_docs fails #148

rgevaert opened this issue Sep 16, 2020 · 4 comments · Fixed by #150

Comments

@rgevaert
Copy link

rgevaert commented Sep 16, 2020 •
edited
Loading

Hi,

terraform-docs has removed the --aggregate-type-defaults flag with the latest release.

https://github.com/terraform-docs/terraform-docs/blob/38316ec246f3eea4ed737f7d8bf54f2faabd6ff2/CHANGELOG.md#v080---2020-01-17

terraform_docs_without_aggregate_type_defaults hook still works. But terraform_docs doesn't anymore because of this.
@antonbabenko
Copy link
Owner

Thanks for opening this issue!

What do you think if have both terraform_docs_without_aggregate_type_defaults and terraform_docs acting identically (for backward compatibility reasons)?

/cc @robinbowes @rgevaert

@rgevaert
Copy link
Author

I am fine with that.

Also maybe #57 is linked to this? In any case it can be closed if this one is closed I think. As I "tested" it.

@antonbabenko antonbabenko mentioned this issue Sep 23, 2020
Merged
@antonbabenko
Copy link
Owner

v1.41.0 has been just released.

@acdha
Copy link

acdha commented Sep 23, 2020

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@acdha @rgevaert @antonbabenko