Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace): Remote Update PR #4

Closed
refcell opened this issue Aug 30, 2024 · 0 comments · Fixed by #16
Closed

feat(workspace): Remote Update PR #4

refcell opened this issue Aug 30, 2024 · 0 comments · Fixed by #16

Comments

@refcell
Copy link
Contributor

refcell commented Aug 30, 2024

Description

Bindings for the superchain-registry are updated using the just bind command. This effectively copies over the configs.toml and chainList.toml static files from the superchain-registry git submodule, into the crates/registry crate so that these files can be read in at compile time.

This issue is multi-pronged.

  • Create a just target (e.g. just source) that updates the superchain-registry git submodule so that it contains updated configs.toml and chainList.toml files. Effectively this should make updating bindings a two-command process: just source && just bind.
  • Create a github action that runs on a nightly schedule that attempts to update the bindings and if a diff is detected (meaning there are updates to the bindings), it creates a PR into main with the updated bindings committed. This will make it easy to tell when the bindings have breaking compatibility with trunk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant