Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Docker Feature Flag #53

Open
refcell opened this issue Oct 12, 2023 · 0 comments
Open

feat(docker): Docker Feature Flag #53

refcell opened this issue Oct 12, 2023 · 0 comments
Labels
A-composer Area: op-composer related C-feature Category: Features M-good-first-issue Meta: Good first issue

Comments

@refcell
Copy link
Collaborator

refcell commented Oct 12, 2023

Description

Creating this issue as a placeholder - it may be useful/necessary to put all docker-dependent code behind a docker feature flag.

Thinking: the op-composer internally has a Docker bollard reference that we may not want to "leak" to the stages crate unless the docker flag is enabled (could be by default unless necessary).

Effectively, a good start would be to add a docker feature flag to the stages crate and hide all docker-dependent code in the crate behind this flag.

@refcell refcell added C-feature Category: Features M-good-first-issue Meta: Good first issue A-composer Area: op-composer related labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-composer Area: op-composer related C-feature Category: Features M-good-first-issue Meta: Good first issue
Projects
None yet
Development

No branches or pull requests

1 participant