Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bin): Clean Subcommand #20

Open
Tracked by #17
refcell opened this issue Oct 3, 2023 · 0 comments
Open
Tracked by #17

feat(bin): Clean Subcommand #20

refcell opened this issue Oct 3, 2023 · 0 comments
Labels
A-bin Area: Binary related alpha C-feature Category: Features M-good-first-issue Meta: Good first issue

Comments

@refcell
Copy link
Collaborator

refcell commented Oct 3, 2023

Description

As part of #17, this task is to introduce a new clean subcommand to op-up that cleans stack artifacts and any additional generated files.

The logic of cleaning a stack based on the config should be abstracted into the Stage Manager orchestrator (doesn't exist yet). This allows the opup cli binary to build the stage manager from the config, and then be able to clean the stack via a simple clean() -> eyre::Result<()> call.

For example

StageManager::from(config).clean()?;

The logic behind building a stage manager orchestrator from the stack config is so that it can handle finding existing running stack components based on the configuration. This separates concerns whereby the stack configuration solely handles component and stack configuration while the stage manager can handle orchestrating the stack stages/components.

Since this logic should be minimal, it can be placed inside cli.rs alongside subcommand dispatching.

@refcell refcell added A-bin Area: Binary related alpha M-good-first-issue Meta: Good first issue labels Oct 3, 2023
@refcell refcell mentioned this issue Oct 3, 2023
6 tasks
@refcell refcell added the C-feature Category: Features label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-bin Area: Binary related alpha C-feature Category: Features M-good-first-issue Meta: Good first issue
Projects
None yet
Development

No branches or pull requests

1 participant