Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change potion structure for plays and game history #130

Closed
antoinezanardi opened this issue Feb 13, 2021 · 0 comments
Closed

Change potion structure for plays and game history #130

antoinezanardi opened this issue Feb 13, 2021 · 0 comments
Assignees
Labels
refactor Refactor code, doesn't change any features
Milestone

Comments

@antoinezanardi
Copy link
Owner

In plays and game history structures, potion(s) usage is represented by { potion: { life: true, death: true } }.

In order to follow boolean variable naming rules and because a target can't drink both potions at the same time, change the structure to:

{
    hasDrankLifePotion: true,
    hasDrankDeathPotion: true,
}
@antoinezanardi antoinezanardi added the refactor Refactor code, doesn't change any features label Feb 13, 2021
@antoinezanardi antoinezanardi added this to the v1.0.0 milestone Feb 13, 2021
@antoinezanardi antoinezanardi self-assigned this Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code, doesn't change any features
Projects
None yet
Development

No branches or pull requests

1 participant