Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Game History Modal #101

Closed
antoinezanardi opened this issue Jan 18, 2021 · 0 comments
Closed

Refactor Game History Modal #101

antoinezanardi opened this issue Jan 18, 2021 · 0 comments
Assignees
@antoinezanardi
Labels
refactor Refactor code, doesn't change any features
Milestone
v1.0.0

Comments

@antoinezanardi
Copy link
Owner

antoinezanardi commented Jan 18, 2021 •
edited
Loading

  • When showing the game history modal, get all history with GET /games/:id/history for full history.
  • Each game history entry, the source property is now an object with name and players. Change the game history modal in order to display all players involved in the game.
  • Implement lazy loading for each history line for faster display.
@antoinezanardi antoinezanardi added the refactor Refactor code, doesn't change any features label Jan 18, 2021
@antoinezanardi antoinezanardi added this to the v1.0.0 milestone Jan 18, 2021
@antoinezanardi antoinezanardi self-assigned this Jan 18, 2021
@antoinezanardi antoinezanardi changed the title Specify action source's players in game history modal Refactor Game History Jan 18, 2021
@antoinezanardi antoinezanardi changed the title Refactor Game History Refactor Game History Modal Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoinezanardi antoinezanardi

Labels
refactor Refactor code, doesn't change any features
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@antoinezanardi