Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: configurable or parameterized time waiting on socket #224

Open
GoogleCodeExporter opened this issue Mar 4, 2016 · 4 comments

Comments

@GoogleCodeExporter
Copy link

Last I saw, javapns waited on a failure notice returned on the socket for 5 
seconds. It'd be nice to be tune this.

Original issue reported on code.google.com by [email protected] on 11 Nov 2014 at 6:33

@GoogleCodeExporter
Copy link
Author

This is pre-tuned based on past experiences with Apple's servers.  Modifying 
this may result in missed responses.

Original comment by [email protected] on 12 Nov 2014 at 7:10

@GoogleCodeExporter
Copy link
Author

Fair enough, and I appreciate it as a probably a sane and generally optimal 
default but that doesn't one should NEVER modify it.

Original comment by [email protected] on 12 Nov 2014 at 7:13

@GoogleCodeExporter
Copy link
Author

What would be the reason(s) to change this?  I'm asking in order to prioritize 
the request properly.

Original comment by [email protected] on 13 Nov 2014 at 5:38

@GoogleCodeExporter
Copy link
Author

5 seconds is a long time to sit on a socket and I might accept some possibility 
of lost responses. Also, given that Apple's servers change over time, 5 seconds 
may be excessive (my experience with failures has been such that I believe it's 
a bit conservative).

Original comment by [email protected] on 14 Nov 2014 at 10:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant