Make write return Int instead of UInt in an obscure code-path. (J…

…uliaLang#54197)
antoine-levitt · Jun 5, 2024 · 6bb8306 · 6bb8306
1 parent 3899e45
commit 6bb8306
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/base/io.jl b/base/io.jl
@@ -804,7 +804,7 @@ unsafe_write(s::IO, p::Ptr, n::Integer) = unsafe_write(s, convert(Ptr{UInt8}, p)
 function write(s::IO, x::Ref{T}) where {T}
     x isa Ptr && error("write cannot copy from a Ptr")
     if isbitstype(T)
-        unsafe_write(s, x, Core.sizeof(T))
+        Int(unsafe_write(s, x, Core.sizeof(T)))
     else
         write(s, x[])
     end

diff --git a/test/filesystem.jl b/test/filesystem.jl
@@ -46,3 +46,7 @@ end
   @test_broken isempty(undoc)
   @test undoc == [:File, :Filesystem, :cptree, :futime, :rename, :sendfile, :unlink]
 end
+
+@testet "write return type" begin
+    @test Base.return_types(write, (Base.Filesystem.File, UInt8)) == [Int]
+end