Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript-runtime] Support TypeScript bundler module resolution for types #4644

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

guidsdo
Copy link
Contributor

@guidsdo guidsdo commented Jun 21, 2024

When using the published npm package in my TypeScript project, TypeScript gave the error that it couldn't find the types.

This fix makes sure that the type field in the package.json is not in a specific exports target, which fixes the issue. The same types are exposed for both the web and node target, so they were combined in the same field.

@ericvergnaud
Copy link
Contributor

@parrt blessed
@guidsdo Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants