Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of reflection in Go.stg #3353

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

KvanTTT
Copy link
Member

@KvanTTT KvanTTT commented Nov 14, 2021

fixes #2278

@jjeffcaii @ericvergnaud please review

Copy link

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@KvanTTT
Copy link
Member Author

KvanTTT commented Dec 13, 2021

@parrt please merge.

@parrt parrt added this to the 4.9.4 milestone Dec 13, 2021
@parrt parrt merged commit 5d6a782 into antlr:master Dec 13, 2021
@parrt
Copy link
Member

parrt commented Dec 13, 2021

thanks!

@KvanTTT KvanTTT deleted the go-improvements branch December 13, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of reflect.TypeOf slows down Go execution by 33%
3 participants