Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLUSTER MEET doesn't allow hostname to be used #2410

Closed
simontabor opened this issue Feb 19, 2015 · 2 comments
Closed

CLUSTER MEET doesn't allow hostname to be used #2410

simontabor opened this issue Feb 19, 2015 · 2 comments

Comments

@simontabor
Copy link

The code at https://github.com/antirez/redis/blob/unstable/src/cluster.c#L1120 rejects everything that isn't a valid IPv4 or IPv6 address.

It'd be great if CLUSTER MEET redis-1 6379 would work (resolved via /etc/hosts).

Current response:

127.0.0.1:6379> cluster meet redis-1 6379
(error) ERR Invalid node address specified: redis-1:6379

There are cases where multiple redis-servers may be running on the same host, and therefore allowing /etc/hosts to resolve that hostname to 127.0.0.1 would be beneficial.
@mattsta
Copy link
Contributor

mattsta commented Feb 19, 2015

Correct. Redis doesn't currently accept hostnames.

Also see #2186 (and kinda #2075 and #2118 too).

@mattsta mattsta closed this as completed Feb 19, 2015
@simontabor
Copy link
Author

Ah, apologies for duplicate

@badboy badboy mentioned this issue May 5, 2015
Closed
@allanwax allanwax mentioned this issue Jul 30, 2015
Open
@simontabor simontabor mentioned this issue Sep 21, 2015
Closed
@luin luin mentioned this issue Oct 7, 2018
Closed
luin added a commit to redis/ioredis that referenced this issue Oct 15, 2018
@luin
feat: support customize dns lookup function
39bdc29 
Since Redis cluster doesn't support hostname at all (redis/redis#2410),
it's reasonable to resolve the hostnames to IPs before connecting.
@luin luin mentioned this issue Oct 15, 2018
Merged
luin added a commit to redis/ioredis that referenced this issue Oct 17, 2018
@luin
feat: support customize dns lookup function (#723)
b9c4793 
Since Redis cluster doesn't support hostname at all (redis/redis#2410),
it's reasonable to resolve the hostnames to IPs before connecting.
ioredis-robot pushed a commit to redis/ioredis that referenced this issue Oct 17, 2018
@semantic-release-bot
chore(release): 4.2.0 [skip ci]
b46016a 
# [4.2.0](v4.1.0...v4.2.0) (2018-10-17)

### Features

* support customize dns lookup function ([#723](#723)) ([b9c4793](b9c4793)), closes [redis/redis#2410](redis/redis#2410)
@lauerdev lauerdev mentioned this issue Jun 2, 2023
Closed
@pratikpanchal4472 pratikpanchal4472 mentioned this issue Aug 21, 2023
Open
janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this issue Mar 1, 2024
@janus-dev87
feat: support customize dns lookup function (#723)
1daf1c6 
Since Redis cluster doesn't support hostname at all (redis/redis#2410),
it's reasonable to resolve the hostnames to IPs before connecting.
janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this issue Mar 1, 2024
@janus-dev87
chore(release): 4.2.0 [skip ci]
b283c6b 
# [4.2.0](redis/ioredis@v4.1.0...v4.2.0) (2018-10-17)

### Features

* support customize dns lookup function ([#723](redis/ioredis#723)) ([b9c4793](redis/ioredis@b9c4793)), closes [redis/redis#2410](redis/redis#2410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsta @simontabor