Adding new functions to Node

[suntong]

Basically, all functions defined in

xmlquery/node_test.go

Lines 11 to 69 in e73954f

	func findRoot(n *Node) *Node {
	if n == nil {
	return nil
	}
	for ; n.Parent != nil; n = n.Parent {
	}
	return n
	}
	func findNode(root *Node, name string) *Node {
	node := root.FirstChild
	for {
	if node == nil || node.Data == name {
	break
	}
	node = node.NextSibling
	}
	return node
	}
	func childNodes(root *Node, name string) []*Node {
	var list []*Node
	node := root.FirstChild
	for {
	if node == nil {
	break
	}
	if node.Data == name {
	list = append(list, node)
	}
	node = node.NextSibling
	}
	return list
	}
	func testNode(t *testing.T, n *Node, expected string) {
	if n.Data != expected {
	t.Fatalf("expected node name is %s,but got %s", expected, n.Data)
	}
	}
	func testAttr(t *testing.T, n *Node, name, expected string) {
	for _, attr := range n.Attr {
	if attr.Name.Local == name && attr.Value == expected {
	return
	}
	}
	t.Fatalf("not found attribute %s in the node %s", name, n.Data)
	}
	func testValue(t *testing.T, val, expected interface{}) {
	if val == expected {
	return
	}
	if reflect.DeepEqual(val, expected) {
	return
	}
	t.Fatalf("expected value is %+v, but got %+v", expected, val)
	}

are necessary for me for my node navigation & checking, and I'd like to move them into node and expose them,

while changing (in node.go alone)

• testNode to func IsNode(n *Node, expected string) bool
• testAttr to func HasAttr(n *Node, expected string) bool and
• testValue to func HasValue(val, expected interface{}) bool

OK?

[zhengchun]

It makes no sense to add IsNode, HasAttr and HasValue to node.go. Node already have InnerText() and SelectAttr() to help finish these logical operation.

[suntong]

OK. I'll leave them alone.

How about the rest of the functions then?

[suntong]

Ping

How about the rest of the functions?