From 38bfea279ce93366dfd2021d0e91622a5a88878e Mon Sep 17 00:00:00 2001
From: Fabio Di Stasio <fabio286@gmail.com>
Date: Wed, 5 Jul 2023 18:27:30 +0200
Subject: [PATCH] feat: button to open table settings tab, closes #608

---
 src/renderer/components/Workspace.vue         |  8 ++---
 .../WorkspaceExploreBarTableContext.vue       |  4 +--
 src/renderer/components/WorkspaceTabTable.vue | 33 +++++++++++++++++--
 3 files changed, 37 insertions(+), 8 deletions(-)

diff --git a/src/renderer/components/Workspace.vue b/src/renderer/components/Workspace.vue
index eac38a3e..d4df1531 100644
--- a/src/renderer/components/Workspace.vue
+++ b/src/renderer/components/Workspace.vue
@@ -104,7 +104,7 @@
                      class="tab-link"
                      :class="{'badge': element.isChanged}"
                   >
-                     <i class="mdi mdi-tune-vertical-variant mdi-18px mr-1" />
+                     <i class="mdi mdi-wrench-cog mdi-18px mr-1" />
                      <span :title="`${t('word.settings').toUpperCase()}: ${t(`word.${element.elementType}`)}`">
                         {{ cutText(element.elementName, 20, true) }}
                         <span
@@ -121,7 +121,7 @@
                      class="tab-link"
                      :class="{'badge': element.isChanged}"
                   >
-                     <i class="mdi mdi-tune-vertical-variant mdi-18px mr-1" />
+                     <i class="mdi mdi-wrench-cog mdi-18px mr-1" />
                      <span :title="`${t('word.settings').toUpperCase()}: ${t(`word.view`)}`">
                         {{ cutText(element.elementName, 20, true) }}
                         <span
@@ -241,7 +241,7 @@
                      :class="{'badge': element.isChanged}"
                      @dblclick="openAsPermanentTab(element)"
                   >
-                     <i class="mdi mdi-18px mdi-tune-vertical-variant mr-1" />
+                     <i class="mdi mdi-18px mdi-wrench-cog mr-1" />
                      <span :title="`${t('word.settings').toUpperCase()}: ${t(`word.${element.elementType}`)}`">
                         <span class=" text-italic">{{ cutText(element.elementName, 20, true) }}</span>
                         <span
@@ -258,7 +258,7 @@
                      class="tab-link"
                      :class="{'badge': element.isChanged}"
                   >
-                     <i class="mdi mdi-18px mdi-tune-vertical-variant mr-1" />
+                     <i class="mdi mdi-18px mdi-wrench-cog mr-1" />
                      <span :title="`${t('word.settings').toUpperCase()}: ${t(`word.${element.elementType}`)}`">
                         {{ cutText(element.elementName, 20, true) }}
                         <span
diff --git a/src/renderer/components/WorkspaceExploreBarTableContext.vue b/src/renderer/components/WorkspaceExploreBarTableContext.vue
index e5f81020..b48dacb7 100644
--- a/src/renderer/components/WorkspaceExploreBarTableContext.vue
+++ b/src/renderer/components/WorkspaceExploreBarTableContext.vue
@@ -8,14 +8,14 @@
          class="context-element"
          @click="openTableSettingTab"
       >
-         <span class="d-flex"><i class="mdi mdi-18px mdi-tune-vertical-variant text-light pr-1" /> {{ t('word.settings') }}</span>
+         <span class="d-flex"><i class="mdi mdi-18px mdi-wrench-cog text-light pr-1" /> {{ t('word.settings') }}</span>
       </div>
       <div
          v-if="selectedTable && selectedTable.type === 'view' && customizations.viewSettings"
          class="context-element"
          @click="openViewSettingTab"
       >
-         <span class="d-flex"><i class="mdi mdi-18px mdi-tune-vertical-variant text-light pr-1" /> {{ t('word.settings') }}</span>
+         <span class="d-flex"><i class="mdi mdi-18px mdi-wrench-cog text-light pr-1" /> {{ t('word.settings') }}</span>
       </div>
       <div
          v-if="selectedTable && selectedTable.type === 'table' && customizations.tableDuplicate"
diff --git a/src/renderer/components/WorkspaceTabTable.vue b/src/renderer/components/WorkspaceTabTable.vue
index da542c47..0bfcf4dc 100644
--- a/src/renderer/components/WorkspaceTabTable.vue
+++ b/src/renderer/components/WorkspaceTabTable.vue
@@ -89,7 +89,7 @@
                   <span>{{ t('message.insertRow', 2) }}</span>
                </button>
 
-               <div class="dropdown table-dropdown pr-2">
+               <div class="dropdown table-dropdown">
                   <button
                      :disabled="isQuering"
                      class="btn btn-dark btn-sm dropdown-toggle mr-0 pr-0"
@@ -114,6 +114,19 @@
                      </li>
                   </ul>
                </div>
+
+               <div class="divider-vert py-3" />
+
+               <button
+                  v-if="isTable"
+                  class="btn btn-dark btn-sm"
+                  :disabled="isQuering"
+                  :title="t('word.settings')"
+                  @click="openTableSettingTab()"
+               >
+                  <i class="mdi mdi-24px mdi-cog" />
+                  <!-- <span>{{ t('word.settings') }}</span> -->
+               </button>
             </div>
             <div class="workspace-query-info">
                <div
@@ -203,6 +216,7 @@ import { ConnectionParams } from 'common/interfaces/antares';
 import { TableFilterClausole } from 'common/interfaces/tableApis';
 import { useFilters } from '@/composables/useFilters';
 import { ipcRenderer } from 'electron';
+import { table } from 'console';
 
 const { localeString } = useFilters();
 
@@ -231,7 +245,7 @@ const workspacesStore = useWorkspacesStore();
 
 const { dataTabLimit: limit } = storeToRefs(settingsStore);
 
-const { changeBreadcrumbs, getWorkspace } = workspacesStore;
+const { changeBreadcrumbs, getWorkspace, newTab } = workspacesStore;
 
 const pageSelect: Ref<HTMLInputElement> = ref(null);
 const tabUid = ref('data');
@@ -428,6 +442,21 @@ const hasApproximately = computed(() => {
       results.value[0].rows.length < approximateCount.value;
 });
 
+const openTableSettingTab = () => {
+   newTab({
+      uid: workspace.value.uid,
+      elementName: props.table,
+      schema: props.schema,
+      type: 'table-props',
+      elementType: 'table'
+   });
+
+   changeBreadcrumbs({
+      schema: props.schema,
+      table: props.table
+   });
+};
+
 watch(() => props.schema, () => {
    if (props.isSelected) {
       page.value = 1;