-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include 64-bit libraries in releases #33
Comments
Yeah you are right, when do you need to get this issue done? Is it urgent? |
We're looking at adding an RTMP extension to ExoPlayer that has a dependency on this project (google/ExoPlayer#2503). It's not urgent other than we have developers who want (and will be happy to get) such an extension :). I think we'd want this issue and also #30 / #31 / #32 fixed before we go ahead and commit, so from our perspective we'd rather see a release that takes a bit longer and fixes all four than a quick release that fixes this issue only. Lack of error propagation from read(), as well as read() being able to return 0, are particularly problematic. |
Note: You could potentially release both 32bit only and 32+64bit modules, if you want the option of keeping the size small for applications for whom the existing release works correctly. |
The aar for the most recent release (here) only contains 32-bit .so files in the jni directory.
This means the RTMP library fails to load with UnsatisfiedLinkError if the application using the library also uses any other dependency that does contain 64-bit .so files. This happens because Android cannot load 32-bit and 64-bit libraries concurrently, as described here. There are hacky workaround to this issue, but they're really not ideal.
Please could you include 64-bit variant .so files in the release? Thanks!
The text was updated successfully, but these errors were encountered: