-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create): suppport template input, custom npm client #21
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
======================================
Coverage 90.9% 90.9%
======================================
Files 2 2
Lines 11 11
======================================
Hits 10 10
Misses 1 1 Continue to review full report at Codecov.
|
参考 yarn,把 跟社区保持一致 |
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 MR 先合了吧,还有一些细节后面再改
.action(function (directory) { | ||
rawDirectory = directory; | ||
.arguments('[template]') | ||
.arguments('[project-directory]') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该用尖括号吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
尖括号的话只输一个会默认为第一个arg,不是那个必须有的第二个arg。这是个hack。
const options = { | ||
generator: template.source, | ||
generator, | ||
outDir: to, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其实如果上面的变量直接叫 outDir
的话,这里就可以写成 outDir,
了 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下次一起改。
@paradite 来合 然后 npm publish(不要手动改版本号和 changelog 等文件,全部都会自动执行) |
references: