Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create): suppport template input, custom npm client #21

Merged
merged 2 commits into from
Feb 21, 2019

Conversation

paradite
Copy link
Contributor

@paradite paradite commented Feb 21, 2019

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #21   +/-   ##
======================================
  Coverage    90.9%   90.9%           
======================================
  Files           2       2           
  Lines          11      11           
======================================
  Hits           10      10           
  Misses          1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582fdf3...df3d82a. Read the comment docs.

@antife-yinyue
Copy link
Contributor

antife-yinyue commented Feb 21, 2019

参考 yarn,把 create-* 转换成 apfe create * ?就是省掉 create-

跟社区保持一致

@paradite
Copy link
Contributor Author

参考 yarn,把 create-* 转换成 apfe create * ?就是省掉 create-

跟社区保持一致

updated

Copy link
Contributor

@antife-yinyue antife-yinyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 MR 先合了吧,还有一些细节后面再改

.action(function (directory) {
rawDirectory = directory;
.arguments('[template]')
.arguments('[project-directory]')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该用尖括号吧?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

尖括号的话只输一个会默认为第一个arg,不是那个必须有的第二个arg。这是个hack。

const options = {
generator: template.source,
generator,
outDir: to,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实如果上面的变量直接叫 outDir 的话,这里就可以写成 outDir, 了 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下次一起改。

@zhangyuheng
Copy link
Contributor

zhangyuheng commented Feb 21, 2019

@paradite 来合

然后 npm publish(不要手动改版本号和 changelog 等文件,全部都会自动执行)

@paradite paradite merged commit 87afc00 into master Feb 21, 2019
@paradite paradite deleted the npm-client-template-support branch February 21, 2019 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants