Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PropTypes from 'prop-types' mdoule instead of React #5723

Merged
merged 1 commit into from
Apr 12, 2017

Conversation

manjitkumar
Copy link

@manjitkumar manjitkumar commented Apr 11, 2017

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you propose PR to correct branch: bugfix for master, feature for latest active branch feature-x.x. (I am not sure about this, please help me raise this PR against correct branch)
  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

 - as React.PropTypes is being deprecated
 - Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.
 - Solution: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.proptypes
@mention-bot
Copy link

@manjitkumar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163, @benjycui and @yesmeck to be potential reviewers.

@codecov
Copy link

codecov bot commented Apr 11, 2017

Codecov Report

Merging #5723 into master will increase coverage by 0.04%.
The diff coverage is 89.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5723      +/-   ##
==========================================
+ Coverage    86.7%   86.74%   +0.04%     
==========================================
  Files         183      183              
  Lines        4513     4527      +14     
  Branches     1308     1308              
==========================================
+ Hits         3913     3927      +14     
  Misses        600      600
Impacted Files Coverage Δ
components/date-picker/createPicker.tsx 84.31% <ø> (ø) ⬆️
components/select/index.tsx 100% <100%> (ø) ⬆️
components/date-picker/RangePicker.tsx 91.39% <100%> (+0.09%) ⬆️
components/form/FormItem.tsx 95.9% <100%> (+0.03%) ⬆️
components/anchor/AnchorLink.tsx 93.47% <100%> (+0.14%) ⬆️
components/anchor/index.tsx 91.07% <100%> (+0.16%) ⬆️
components/grid/row.tsx 100% <100%> (ø) ⬆️
components/modal/Modal.tsx 90% <100%> (+0.25%) ⬆️
components/locale-provider/index.tsx 89.47% <100%> (+0.58%) ⬆️
components/breadcrumb/Breadcrumb.tsx 86.66% <100%> (+0.3%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa7419a...4e055ed. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Apr 12, 2017

ref #5678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants