Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Collapse border radius issue #48561

Merged
merged 6 commits into from
Apr 22, 2024
Merged

fix: Collapse border radius issue #48561

merged 6 commits into from
Apr 22, 2024

Conversation

hamzaseif13
Copy link
Contributor

@hamzaseif13 hamzaseif13 commented Apr 20, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Collapse bottom border looks weird, the problem is the collapse parent component doesn't have a bottom border, and every collapse item has border bottom, making the border bottom looks weird and it has some white curved line, this can barely be visible unless zoomed a lot.
my fix is remove borderBottom:0 from parent component, and give borderBottom 0 to the last collapse-item.

Before
image

After
image

📝 Changelog

Language Changelog
🇺🇸 English Fix Collapse bottom border issue
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Signed-off-by: Hamza Seif <[email protected]>
Copy link

stackblitz bot commented Apr 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

  • 🚨 Please fill changelog in the PR

    • Write with a developer-oriented perspective and narrative method, without describing the details of the repair
    • Describing the problem and the impact on the developer
    • describing the user-first site problem, not your solution
    • Refer: https://ant.design/changelog#501
  • 🚨 请填写 PR 中的 changelog

    • 请用面向开发者的角度叙述方式撰写,不描述修复细节
    • 描述问题和对开发者的影响
    • 描述用户第一现场的问题,而非你的解决方式
    • 参考:https://ant.design/changelog-cn#501

Copy link
Contributor

github-actions bot commented Apr 20, 2024

👁 Visual Regression Report for PR #48561 Failed ❌

🎯 Target branch: master (50d8201)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
collapse-accordion.dark.png collapse-accordion.dark.png collapse-accordion.dark.png collapse-accordion.dark.png
collapse-accordion.dark.png collapse-accordion.dark.png collapse-accordion.dark.css-var.png collapse-accordion.dark.css-var.png
collapse-basic.dark.png collapse-basic.dark.png collapse-basic.dark.png collapse-basic.dark.png
collapse-basic.dark.png collapse-basic.dark.png collapse-basic.dark.css-var.png collapse-basic.dark.css-var.png
collapse-collapsible.dark.png collapse-collapsible.dark.png collapse-collapsible.dark.png collapse-collapsible.dark.png
collapse-collapsible.dark.png collapse-collapsible.dark.png collapse-collapsible.dark.css-var.png collapse-collapsible.dark.css-var.png
collapse-extra.dark.png collapse-extra.dark.png collapse-extra.dark.png collapse-extra.dark.png
collapse-extra.dark.png collapse-extra.dark.png collapse-extra.dark.css-var.png collapse-extra.dark.css-var.png
collapse-mix.dark.png collapse-mix.dark.png collapse-mix.dark.png collapse-mix.dark.png
collapse-mix.dark.png collapse-mix.dark.png collapse-mix.dark.css-var.png collapse-mix.dark.css-var.png

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 20, 2024

Preview is ready

Copy link

codesandbox-ci bot commented Apr 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (50d8201) to head (5dfa8dc).

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #48561    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          745       745            
  Lines        13603     12947   -656     
  Branches      3628      3383   -245     
==========================================
- Hits         13603     12947   -656     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 changed the title Fix collapse border issue fix: Collapse border radius issue Apr 22, 2024
@afc163 afc163 merged commit 09cb3f4 into ant-design:master Apr 22, 2024
60 of 61 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants